Opened 5 years ago

Closed 5 years ago

#15356 closed (wontfix)

Possible problem with setting import in django/http/

Reported by: mila Owned by: nobody
Component: HTTP handling Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Comments in QueryDict _get_encoding and __init__ methods say:

*Important*: do not import settings at the module level because of the note in core.handlers.modpython.

and settings are imported inside these methods: and

But settings ARE imported at the module level too:

Change History (1)

comment:1 Changed 5 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

I'm going to mark this wontfix, but only because it's a *possible* problem that hasn't manifested itself in an obvious way in the three years since the import in question was introduced.

If anyone can demonstrate that this is a real problem, feel free to reopen.

Note: See TracTickets for help on using tickets.
Back to Top