Opened 15 years ago
Closed 15 years ago
#15356 closed (wontfix)
Possible problem with setting import in django/http/__init__.py
| Reported by: | Miloslav Pojman | Owned by: | nobody |
|---|---|---|---|
| Component: | HTTP handling | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Comments in QueryDict _get_encoding and __init__ methods say:
*Important*: do not import settings at the module level because of the note in core.handlers.modpython.
and settings are imported inside these methods:
http://code.djangoproject.com/browser/django/trunk/django/http/__init__.py#L327 and
http://code.djangoproject.com/browser/django/trunk/django/http/__init__.py#L339
But settings ARE imported at the module level too:
http://code.djangoproject.com/browser/django/trunk/django/http/__init__.py#L124
I'm going to mark this wontfix, but only because it's a *possible* problem that hasn't manifested itself in an obvious way in the three years since the import in question was introduced.
If anyone can demonstrate that this is a real problem, feel free to reopen.