Opened 6 years ago

Closed 6 years ago

#15333 closed (wontfix)

syncdb should use commit_on_success

Reported by: corbellini.andrea@… Owned by: nobody
Component: Uncategorized Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The "syncdb" command of the manager should use commit_on_success(). This will make the script faster and also a bit safer.

Change History (1)

comment:1 Changed 6 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: wontfix
Status: newclosed

I'm not convinced that this is worth the effort. For starters, it wouldn't be completely reliable -- MySQL, for example, has an implicit internal transaction for DDL statements. In addition, Initial data insertion is already handled as a single transaction, which is the only really 'risky' part of a sycndb.

I'm willing to be convinced otherwise, but you'll need to provide convincing hard data to demonstrate the advantage.

Note: See TracTickets for help on using tickets.
Back to Top