Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15328 closed (fixed)

Class-based Views (CBV) documentation mistake on method_decorator approach for @login_required

Reported by: André Terra Owned by: Gabriel Hurley
Component: Documentation Version: 1.3-beta
Severity: Keywords: CBV, class-based views, method_decorator, login_required, decorators, documentation, docs, mixin, login
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The code described in the documentation does not work. My attempt to run the code is registered here:

Per Łukasz Rekucki, on django-users, it should be changed to:

class ProtectedView(TemplateView):
   template_name = 'secret.html'

   def dispatch(self, *args, **kwargs):
       return super(ProtectedView, self).dispatch(*args, **kwargs)

I also recommend mentioning alternatives to providing the same functionality, such as the LoginMixin that was suggested by on the same django-users thread:

import settings

class LoginMixin(object):
    def get_test_func(self):
        return getattr(self, 'test_func', lambda u: u.is_authenticated())
    def get_login_url(self):
        return getattr(self, 'login_url', settings.LOGIN_URL)
    def get_redirect_field_name(self):
        return getattr(self, 'redirect_field_name', None)
    def dispatch(self, request, *args, **kwargs):
        from django.contrib.auth.decorators import user_passes_test
        return user_passes_test(
            login_url = self.get_login_url(),
            redirect_field_name = self.get_redirect_field_name()
        )(super(LoginMixin, self).dispatch
        )(request, *args, **kwargs)

Finally, thank you for providing us with this functionality and documentation. It really makes the code for my views leaner, cleaner, meaner.

Best regards,

André Terra

Change History (3)

comment:1 Changed 7 years ago by Gabriel Hurley

Owner: changed from nobody to Gabriel Hurley
Status: newassigned
Triage Stage: UnreviewedAccepted

Yep, taking *args as a parameter is gonna be necessary with the way method_decorator works...

As for LoginMixin, I think it should be treated as a separate issue and ought to have it's own ticket. I have no strong feelings on it, personally. It's a useful recipe, but it strikes me that if it's useful enough to be formally written out in the docs it might as well be included as a mixin OTB. Either way I'm going to treat it as an extraneous issue and not part of the resolution for the actual error in the docs.

comment:2 Changed 7 years ago by Gabriel Hurley

Resolution: fixed
Status: assignedclosed

In [15563]:

Fixed #15328 -- Corrected an example in the CBV docs and added a note about the parameters passed by method_deorator to the method on the class. Thanks to airstrike for the report and lrekucki for the correction.

comment:3 Changed 7 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top