Code

Opened 3 years ago

Closed 3 years ago

#15322 closed (fixed)

Trivial change to AdminAuthenticationForm.clean

Reported by: melinath Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In django.contrib.admin.forms.AdminAuthenticationForm, there is a redundant half of an if statement. This is a trivial aesthetic change which doesn't alter any functionality.

Attachments (1)

unnecessary.diff (686 bytes) - added by melinath 3 years ago.

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by melinath

comment:1 Changed 3 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15569]:

Fixed #15322 -- Removed a redundant check in admin logins. Thanks to melinath for the report.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.