Opened 6 years ago

Closed 6 years ago

#15322 closed (fixed)

Trivial change to AdminAuthenticationForm.clean

Reported by: melinath Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


In django.contrib.admin.forms.AdminAuthenticationForm, there is a redundant half of an if statement. This is a trivial aesthetic change which doesn't alter any functionality.

Attachments (1)

unnecessary.diff (686 bytes) - added by melinath 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by melinath

Attachment: unnecessary.diff added

comment:1 Changed 6 years ago by Russell Keith-Magee

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

In [15569]:

Fixed #15322 -- Removed a redundant check in admin logins. Thanks to melinath for the report.

Note: See TracTickets for help on using tickets.
Back to Top