Opened 4 years ago

Closed 4 years ago

#15266 closed Bug (fixed)

"login_required" for "password_change_done" like "password_change"

Reported by: Stephane Owned by: lasko
Component: contrib.auth Version:
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

There is a "login_required" for "password_change", but nothing for "password_change_done". It would be better to have:

@login_required
def password_change_done [...]

Best regards,

Stephane

Attachments (1)

views_and_tests.diff (1.6 KB) - added by lasko 4 years ago.
patch for views.py and also added tests.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by russellm

  • Component changed from Uncategorized to Authentication
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

An edge case, but seems reasonable. Marking RFC because it's a one line change

comment:2 Changed 4 years ago by russellm

  • Needs tests set
  • Triage Stage changed from Ready for checkin to Accepted

... and, of course, it's not a one line change, because it needs tests. Late night brain not think good.

Changed 4 years ago by lasko

patch for views.py and also added tests.

comment:3 Changed 4 years ago by lasko

  • Has patch set
  • Needs tests unset

Not sure if the tests need to be more complex than the ones I added.

comment:4 Changed 4 years ago by lasko

  • Owner changed from nobody to lasko

comment:5 Changed 4 years ago by lrekucki

  • Severity set to Normal
  • Type set to Bug

comment:6 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16454]:

Fixed #15266 -- Applied login_required decorator to password_change_done view. Thanks, lasko.

Note: See TracTickets for help on using tickets.
Back to Top