Opened 6 years ago

Closed 5 years ago

#15266 closed Bug (fixed)

"login_required" for "password_change_done" like "password_change"

Reported by: Stephane Owned by: Brandon M Height
Component: contrib.auth Version:
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

There is a "login_required" for "password_change", but nothing for "password_change_done". It would be better to have:

@login_required
def password_change_done [...]

Best regards,

Stephane

Attachments (1)

views_and_tests.diff (1.6 KB) - added by Brandon M Height 6 years ago.
patch for views.py and also added tests.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Russell Keith-Magee

Component: UncategorizedAuthentication
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

An edge case, but seems reasonable. Marking RFC because it's a one line change

comment:2 Changed 6 years ago by Russell Keith-Magee

Needs tests: set
Triage Stage: Ready for checkinAccepted

... and, of course, it's not a one line change, because it needs tests. Late night brain not think good.

Changed 6 years ago by Brandon M Height

Attachment: views_and_tests.diff added

patch for views.py and also added tests.

comment:3 Changed 6 years ago by Brandon M Height

Has patch: set
Needs tests: unset

Not sure if the tests need to be more complex than the ones I added.

comment:4 Changed 6 years ago by Brandon M Height

Owner: changed from nobody to Brandon M Height

comment:5 Changed 6 years ago by Łukasz Rekucki

Severity: Normal
Type: Bug

comment:6 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16454]:

Fixed #15266 -- Applied login_required decorator to password_change_done view. Thanks, lasko.

Note: See TracTickets for help on using tickets.
Back to Top