Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#15229 closed (fixed)

URLValidator class to accept ftp links

Reported by: codefisher Owned by: nobody
Component: Core (Other) Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The URLValidator class currently only accepts links that are http or https. I would suggest that maybe adding ftp as well would be valuable. I have attached a patch.

Attachments (2)

diff.txt​ (553 bytes ) - added by codefisher 13 years ago.
15229.patch​ (2.1 KB ) - added by crayz_train 13 years ago.
patch including tests for https, ftp, and ftps urls

Download all attachments as: .zip

Change History (6)

by codefisher, 13 years ago

Attachment: diff.txt​ added

comment:1 by Russell Keith-Magee, 13 years ago

Needs tests: set
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

by crayz_train, 13 years ago

Attachment: 15229.patch​ added

patch including tests for https, ftp, and ftps urls

comment:2 by crayz_train, 13 years ago

Needs tests: unset
Patch needs improvement: unset

PyCon 2011 sprint.

comment:3 by Adrian Holovaty, 13 years ago

Resolution: → fixed
Status: new → closed

In [15847]:

Fixed #15229 -- Improved URLValidator to accept ​ftp:// links. Thanks, codefisher and crayz_train

comment:4 by crayz_train, 13 years ago

I just noticed that I should have updated the comment (http, https, ftp, or ftps).

Note: See TracTickets for help on using tickets.
Back to Top