Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#15229 closed (fixed)

URLValidator class to accept ftp links

Reported by: codefisher Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The URLValidator class currently only accepts links that are http or https. I would suggest that maybe adding ftp as well would be valuable. I have attached a patch.

Attachments (2)

diff.txt (553 bytes) - added by codefisher 5 years ago.
15229.patch (2.1 KB) - added by crayz_train 4 years ago.
patch including tests for https, ftp, and ftps urls

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by codefisher

comment:1 Changed 5 years ago by russellm

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Changed 4 years ago by crayz_train

patch including tests for https, ftp, and ftps urls

comment:2 Changed 4 years ago by crayz_train

  • Needs tests unset
  • Patch needs improvement unset

PyCon 2011 sprint.

comment:3 Changed 4 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

In [15847]:

Fixed #15229 -- Improved URLValidator to accept ftp:// links. Thanks, codefisher and crayz_train

comment:4 Changed 4 years ago by crayz_train

I just noticed that I should have updated the comment (http, https, ftp, or ftps).

Note: See TracTickets for help on using tickets.
Back to Top