Code

Opened 3 years ago

Closed 16 months ago

#15223 closed Bug (wontfix)

The comments app has 2 similar menu items in action

Reported by: sergeybe@… Owned by: aashu_dwivedi
Component: contrib.comments Version: 1.3-beta
Severity: Normal Keywords: actions
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There are two menu items:

  • Delete selected items
  • Remove selected items

I guess one from admin app and one from comments app.

Attachments (0)

Change History (13)

comment:1 Changed 3 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

I agree that this is confusing (I had to explain the difference between "Delete" and "Remove" to several clients before). "Remove" should perhaps be changed to "De-activate", or "Un-publish" or something along those lines.

comment:2 Changed 3 years ago by julien

That was me :)

comment:3 Changed 3 years ago by julien

  • milestone changed from 1.3 to 1.4

Not a bug though, so can't be done for 1.3.

comment:4 Changed 3 years ago by DrMeers

No doubt originally named after the is_removed field on the Comment model, which seems perfectly reasonable until you see it beside the site-wide delete action. Should be a one-line patch. I think "Unpublish selected" sounds appropriate? (describes the effect better than "deactivate" or "hide").

comment:5 Changed 3 years ago by ramiro

  • milestone changed from 1.4 to 1.3

Julien, I disagree, this is a bug, even more a one-line translatable literal change. Can be worked on before 1.3 RC.

comment:6 Changed 3 years ago by julien

@Ramiro Functionally things are consistent but I agree that this can be seen as a usability bug, and I'm absolutely in favour of fixing this ASAP. The patch may not be as trivial as modifying one string though. The term "removed" is also used in the comment's detail page and in the changelist's table and filters. If we change the term only in some places then things may potentially get even more confusing for the user.

comment:7 Changed 3 years ago by lrekucki

  • Severity set to Normal
  • Type set to Bug

comment:8 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

comment:11 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:12 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:13 Changed 2 years ago by aashu_dwivedi

  • Owner changed from nobody to aashu_dwivedi
  • Status changed from new to assigned

I've made a pull request for the patch here https://github.com/aashudwivedi/django/tree/ticket_15223

comment:14 Changed 21 months ago by lukeplant

This is perhaps bikeshedding, but "unpublish/is unpublished" seems pretty clumsy language to me. "hide/is hidden" would be a lot better IMO.

comment:15 Changed 16 months ago by jacob

  • Resolution set to wontfix
  • Status changed from assigned to closed

django.contrib.comments has been deprecated and is no longer supported, so I'm closing this ticket. We're encouraging users to transition to a custom solution, or to a hosted solution like Disqus.

The code itself has moved to https://github.com/django/django-contrib-comments; if you want to keep using it, you could move this bug over there.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.