Allow redefining object to delete collector in Django admin

[Manuel Saelices]

ModelAdmin should be able to redefining easily the objects to delete collector.

[Manuel Saelices]

With this patch you can do something like this:

class FooModelAdmin(admin.ModelAdmin):
    # ...
    def delete_view(self, request, object_id, extra_context=None):
        # ...

        (deleted_objects, perms_needed, protected) = get_deleted_objects(
            [obj], opts, request.user, self.admin_site, using,
            collector_class=CustomNestedObjects)

        # ...

[Manuel Saelices]

Note that the only lines I've changed in patch was this:

def get_deleted_objects(objs, opts, user, admin_site, using):
    """ ... """
    collector = NestedObjects(using=using)

To this:

def get_deleted_objects(objs, opts, user, admin_site, using, collector_class=NestedObjects):
    """ ... """
    collector = collector_class(using=using)

The other changes (marked in green and red in patch) are due because I have to move up the NestedObjects implementation to be accesible by the get_deleted_objects function.

[Alex Gaynor]

Why? What's the usecase here.

[Russell Keith-Magee]

I'm with Alex - I don't see the use case here. THe list of objects to be deleted isn't a matter of debate or control; it's a direct consequence of the delete cascading rules.

If you want to advocate for this change, please start a discussion on django-dev.