#1512 closed enhancement (invalid)
Paginator still uses old api style in magic removal version
| Reported by: | the_deco | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | Template system | Version: | magic-removal |
| Severity: | minor | Keywords: | paginator |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The Object "ObjectPaginator" from the Paginator package has still old api style calls which should be replaced:
In [12]: ObjectPaginator. ObjectPaginator._get_hits ObjectPaginator.get_page ObjectPaginator.has_previous_page ObjectPaginator.pages ObjectPaginator._get_pages ObjectPaginator.has_next_page ObjectPaginator.hits
Namely, these are all methods with get_ in their name. These should be adjusted to the new api style to not cause confusion,
e.g. ObjectPaginator.get_page -> ObjectPaginator.page
This is just a personal opinion because it confused me while I was migrating to magic removal so feel free to flame me ;)
decoder
Change History (3)
comment:1 by , 19 years ago
| milestone: | Version 0.91 → Version 0.92 |
|---|
comment:2 by , 18 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
I cannot see the need to fix anything here. ObjectPaginator is not a QuerySet and any temporary confusion from porting to 0.91 to post-magic-removal-merge is very temporary. A massive renaming at this point would hurt more than help, so I'm going to close this.