Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#15061 closed (fixed)

Remove redundant code in ModelFormMixin

Reported by: rasca Owned by: rasca
Component: Generic views Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

ModelFormMinix inherits from FormMinix, and overrides the form_invalid() method doing the same thing.

I've ran all django tests and all of them passes when removing this method from ModelFormMixin.

Attachments (1)

ticket15061.patch​ (5.0 KB ) - added by rasca 13 years ago.
remove duplicate code and pep8 whitelines fix

Download all attachments as: .zip

Change History (6)

by rasca, 13 years ago

Attachment: ticket15061.patch​ added

remove duplicate code and pep8 whitelines fix

comment:1 by rasca, 13 years ago

Owner: changed from nobody to rasca
Status: new → assigned

comment:2 by rasca, 13 years ago

Has patch: set

comment:3 by Russell Keith-Magee, 13 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:4 by Russell Keith-Magee, 13 years ago

Resolution: → fixed
Status: assigned → closed

(In [15341]) Fixed #15061 -- Removed a redundant method implementation in the class-based ModelFormMixin, and did some PEP8 cleanup. Thanks to rasca for the report and patch.

comment:5 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top