Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#15061 closed (fixed)

Remove redundant code in ModelFormMixin

Reported by: rasca Owned by: rasca
Component: Generic views Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

ModelFormMinix inherits from FormMinix, and overrides the form_invalid() method doing the same thing.

I've ran all django tests and all of them passes when removing this method from ModelFormMixin.

Attachments (1)

ticket15061.patch (5.0 KB) - added by rasca 4 years ago.
remove duplicate code and pep8 whitelines fix

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by rasca

remove duplicate code and pep8 whitelines fix

comment:1 Changed 4 years ago by rasca

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to rasca
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 4 years ago by rasca

  • Has patch set

comment:3 Changed 4 years ago by russellm

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:4 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [15341]) Fixed #15061 -- Removed a redundant method implementation in the class-based ModelFormMixin, and did some PEP8 cleanup. Thanks to rasca for the report and patch.

comment:5 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top