Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#15061 closed (fixed)

Remove redundant code in ModelFormMixin

Reported by: rasca Owned by: rasca
Component: Generic views Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

ModelFormMinix inherits from FormMinix, and overrides the form_invalid() method doing the same thing.

I've ran all django tests and all of them passes when removing this method from ModelFormMixin.

Attachments (1)

ticket15061.patch (5.0 KB) - added by rasca 6 years ago.
remove duplicate code and pep8 whitelines fix

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by rasca

Attachment: ticket15061.patch added

remove duplicate code and pep8 whitelines fix

comment:1 Changed 6 years ago by rasca

Owner: changed from nobody to rasca
Status: newassigned

comment:2 Changed 6 years ago by rasca

Has patch: set

comment:3 Changed 6 years ago by Russell Keith-Magee

Triage Stage: UnreviewedReady for checkin

comment:4 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: assignedclosed

(In [15341]) Fixed #15061 -- Removed a redundant method implementation in the class-based ModelFormMixin, and did some PEP8 cleanup. Thanks to rasca for the report and patch.

comment:5 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top