Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#15046 closed (fixed)

"chromeframe" should be added as an alias for "MSIE" in IE fixes (fix_IE_for_attach, fix_IE_for_vary)

Reported by: chrj Owned by: nobody
Component: HTTP handling Version: master
Severity: Keywords: ie chromeframe
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Chromeframe is an extension for Internet Explorer allowing it to use Google Chrome to process and render the requests and responses of the client. In recent versions chromeframe has stopped identifying itself as an Internet Explorer (with the 'MSIE' token), and it now identifies itself as a Chrome browser. Example:

# Then
User-Agent : Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; GTB6.4; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.0.30729; .NET CLR 3.5.30729) chromeframe/5.0.366.4
# Now
User-Agent : Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.224 Safari/534.10 chromeframe/8.0.552.224

However the IE quirks fix_IE_for_attach and fix_IE_for_vary was implemented to fix is still present.

I recommend 'chromeframe' is added as an "alias" to 'MSIE' when applying these fixes to the response. I have attached a patch for this.

Attachments (1)

chromeframe_fix_rev_15168.diff (1.0 KB) - added by chrj 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by chrj

comment:1 Changed 3 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [15340]) Fixed #15046 -- Added "CHROMEFRAME" as a user agent alias for various MSIE fixes. Thanks to chrj for the report and patch.

comment:3 Changed 3 years ago by russellm

(In [15344]) [1.2.X] Fixed #15046 -- Added "CHROMEFRAME" as a user agent alias for various MSIE fixes. Thanks to chrj for the report and patch.

Backport of r15340 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.