Code

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#15021 closed (fixed)

Debug page code double-spaced, kinda

Reported by: kmtracey Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: blocker
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Since r14844, the debug page code appears double-spaced in Firefox. The actual content of lines of code appear on the line below the line with the line number. Chrome looks better, but even there the ellipsis at the end of the current line of code is placed on its own line, so there's a funny almost-blank line below the current line of code in the traceback portion of the page. I haven't tried any other browsers to see how they look.

Attachments (1)

cross_browser_debug.diff (1.6 KB) - added by EmilStenstrom 4 years ago.
Update: Use pixels instead of em:s.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by russellm

  • Component changed from Uncategorized to Core framework
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Oh, I do so love CSS.

This is a change in trunk, so it's a release blocker.

comment:2 Changed 4 years ago by russellm

  • Keywords blocker added

comment:4 Changed 4 years ago by EmilStenstrom

  • Has patch set

Added a quick patch that fixes the double spacing issue. My first patch, so let me know if I'm "doing it wrong".

Here's how it looks in (in order): IE7, IE8, IE9, Firefox 4b8, Chrome 10.0.612.3 dev, Safari 5.0.3. All on Windows: http://twitpic.com/3nbrh6/full

Needs more testing on more browsers, and I'm counting on your help with testing this.

(IMHO: The real solution would be to rewrite the CSS and HTML with a proper CSS reset in place. But that would not make it in time for 1.3)

Changed 4 years ago by EmilStenstrom

Update: Use pixels instead of em:s.

comment:5 Changed 3 years ago by ramiro

  • Triage Stage changed from Accepted to Ready for checkin

Verified that the latest patch also corrects the issue on Chrome 6.x, Firefox 3.5.x and KDE's Konqueror 4.5.x all on Linux.

comment:6 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [15294]) Fixed #15021 -- Corrected CSS for the layout of stack traces on the server error page. Thanks to EmilStenstrom for the patch.

comment:7 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.