#15021 closed (fixed)
Debug page code double-spaced, kinda
Reported by: | Karen Tracey | Owned by: | nobody |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Keywords: | blocker | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Since r14844, the debug page code appears double-spaced in Firefox. The actual content of lines of code appear on the line below the line with the line number. Chrome looks better, but even there the ellipsis at the end of the current line of code is placed on its own line, so there's a funny almost-blank line below the current line of code in the traceback portion of the page. I haven't tried any other browsers to see how they look.
Attachments (1)
Change History (8)
comment:1 by , 14 years ago
Component: | Uncategorized → Core framework |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
Keywords: | blocker added |
---|
comment:3 by , 14 years ago
Russ, you want one of these: http://thenextweb.com/shareables/files/2010/06/6709_540-500x267.jpg
comment:4 by , 14 years ago
Has patch: | set |
---|
Added a quick patch that fixes the double spacing issue. My first patch, so let me know if I'm "doing it wrong".
Here's how it looks in (in order): IE7, IE8, IE9, Firefox 4b8, Chrome 10.0.612.3 dev, Safari 5.0.3. All on Windows: http://twitpic.com/3nbrh6/full
Needs more testing on more browsers, and I'm counting on your help with testing this.
(IMHO: The real solution would be to rewrite the CSS and HTML with a proper CSS reset in place. But that would not make it in time for 1.3)
comment:5 by , 14 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Verified that the latest patch also corrects the issue on Chrome 6.x, Firefox 3.5.x and KDE's Konqueror 4.5.x all on Linux.
comment:6 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Oh, I do so love CSS.
This is a change in trunk, so it's a release blocker.