TemplateResponse: add current_app parameter for RequestContext

[Chris Adams]

#15008 converts admin to return TemplateResponse instances. ​The patch is complicated by the fact that we still have to create RequestContext instances manually to set current_app in many places. This branch / patch changes TemplateResponse to pass through the current_app value when creating a RequestContext instance dynamically:

​https://github.com/acdha/django/compare/master...template-response-current_app
​https://github.com/acdha/django/compare/master...template-response-current_app.patch

[Russell Keith-Magee]

Good catch. For the record, the same problem exists with the render() shortcut. Marking needs improvement so that we can roll that fix into the same commit.

Also requires docs.

Since this is a functional flaw in a 1.3 feature, this should be a 1.3 blocker.

[Chris Adams]

Added the render shortcut and some basic documentation here, which is the commit used for the updated patch:

​https://github.com/acdha/django/commit/d1024ace8965230d5eac7d2a7a8cefeeefc3b36d

Do you have any suggestions for further improvements?

Also, at this point, I should assume that it's safe to update #15008 to assume that this change will be included, right?

[Chris Adams]

Updated patch and corrected the filename

[Jannis Leidel]

Replying to acdha:

Added the render shortcut and some basic documentation here, which is the commit used for the updated patch:

Also, at this point, I should assume that it's safe to update #15008 to assume that this change will be included, right?

Yup.

[Jannis Leidel]

(In [15153]) Fixed #15010 -- Added current_app parameter to close gap between TemplateResponse and render method. Thanks, acdha.

[Jacob]

Milestone 1.3 deleted