Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14977 closed Uncategorized (duplicate)

contrib.admin ordering by two or more fields

Reported by: Evan Carmi Owned by: nobody
Component: contrib.admin Version: 1.3-alpha
Severity: Normal Keywords: admin ordering order
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX:

Description

The contrib.admin app does not support ordering by more than one field. The ordering list/tuple is always truncated to the first element ignoring all others. I recently ran into a situation where I needed to sort by two fields and found that the admin was unable to do this. I have created a patch that implements this feature. Feedback on the patch would be appreciated. Documentation and tests to follow.

Attachments (2)

ticket14977.diff (5.0 KB) - added by Evan Carmi 6 years ago.
admin_multi_ordering.patch (5.0 KB) - added by Florian Sening 5 years ago.
updated patch for 1.3 trunk

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Evan Carmi

Attachment: ticket14977.diff added

comment:1 Changed 6 years ago by Karen Tracey

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: duplicate
Status: newclosed

There's already a ticket open for this: #11868

comment:2 Changed 6 years ago by samjacoby

Needs tests: set
Resolution: duplicate
Status: closedreopened

Not a duplicate, though there are plenty of duplicates out there: 4926, the UI example given.

Last edited 6 years ago by samjacoby (previous) (diff)

comment:3 Changed 6 years ago by samjacoby

Resolution: duplicate
Status: reopenedclosed

Changed 5 years ago by Florian Sening

Attachment: admin_multi_ordering.patch added

updated patch for 1.3 trunk

comment:4 Changed 5 years ago by Florian Sening

Severity: Normal
Type: Uncategorized

I really don't understand why this is closed. This has been marked as a duplicate for #4926 but this in turn has been marked as a duplicate for #11868 because of a better approach and a more recent patch. The patch isn't even working on trunk and the whole approach wants way too much. Could we just submit this patch which would fix the underlying problem without trying to fix the ui?

comment:5 Changed 5 years ago by Jacob

Easy pickings: unset

No, the UI's part of the issue and needs to be fixed as part of it. #11868 is looking fairly good, so if you want to move it along give the patch there a review, check that it covers your use case, and help update it to trunk if you can.

comment:6 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top