Opened 6 years ago

Closed 6 years ago

#14960 closed (fixed)

Write tests for inclusion_tag

Reported by: Julien Phalip Owned by: Paul Bissex
Component: Template system Version: 1.2
Severity: Keywords: easy-pickings
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The inclusion_tag decorator doesn't seem to have any regression tests. The tests recently added for simple_tag (see [14987]) could be used as a good example.

Attachments (2)

tests.diff (4.4 KB) - added by Andy Venet 6 years ago.
Made some tests based on the ones on simple_tag
patch2.diff (4.3 KB) - added by Paul Bissex 6 years ago.
updated diff

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by rasca

Component: UncategorizedTemplate system
Keywords: easy-pickings added
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Accepting the ticket and marking it as easy-picking

comment:2 Changed 6 years ago by elbarto

Owner: changed from nobody to elbarto

comment:3 Changed 6 years ago by Andy Venet

Owner: changed from elbarto to Andy Venet

comment:4 Changed 6 years ago by Andy Venet

Status: newassigned

Changed 6 years ago by Andy Venet

Attachment: tests.diff added

Made some tests based on the ones on simple_tag

comment:5 Changed 6 years ago by Andy Venet

Has patch: set

comment:6 Changed 6 years ago by Paul Bissex

Owner: changed from Andy Venet to Paul Bissex
Status: assignednew

comment:7 Changed 6 years ago by Paul Bissex

Patch needs improvement: set

Changed 6 years ago by Paul Bissex

Attachment: patch2.diff added

updated diff

comment:8 Changed 6 years ago by Paul Bissex

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:9 Changed 6 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

In [15819]:

Fixed #14960 -- Added tests for inclusion tags. Thanks to Julien Phalip for the report, and to avenet and Paul Bissex for the patch.

Note: See TracTickets for help on using tickets.
Back to Top