Opened 5 years ago

Closed 4 years ago

#14960 closed (fixed)

Write tests for inclusion_tag

Reported by: julien Owned by: pbx
Component: Template system Version: 1.2
Severity: Keywords: easy-pickings
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The inclusion_tag decorator doesn't seem to have any regression tests. The tests recently added for simple_tag (see [14987]) could be used as a good example.

Attachments (2)

tests.diff (4.4 KB) - added by avenet 4 years ago.
Made some tests based on the ones on simple_tag
patch2.diff (4.3 KB) - added by pbx 4 years ago.
updated diff

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by rasca

  • Component changed from Uncategorized to Template system
  • Keywords easy-pickings added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Accepting the ticket and marking it as easy-picking

comment:2 Changed 5 years ago by elbarto

  • Owner changed from nobody to elbarto

comment:3 Changed 4 years ago by avenet

  • Owner changed from elbarto to avenet

comment:4 Changed 4 years ago by avenet

  • Status changed from new to assigned

Changed 4 years ago by avenet

Made some tests based on the ones on simple_tag

comment:5 Changed 4 years ago by avenet

  • Has patch set

comment:6 Changed 4 years ago by pbx

  • Owner changed from avenet to pbx
  • Status changed from assigned to new

comment:7 Changed 4 years ago by pbx

  • Patch needs improvement set

Changed 4 years ago by pbx

updated diff

comment:8 Changed 4 years ago by pbx

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

comment:9 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15819]:

Fixed #14960 -- Added tests for inclusion tags. Thanks to Julien Phalip for the report, and to avenet and Paul Bissex for the patch.

Note: See TracTickets for help on using tickets.
Back to Top