Opened 13 years ago

Closed 13 years ago

#14960 closed (fixed)

Write tests for inclusion_tag

Reported by: Julien Phalip Owned by: Paul Bissex
Component: Template system Version: 1.2
Severity: Keywords: easy-pickings
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The inclusion_tag decorator doesn't seem to have any regression tests. The tests recently added for simple_tag (see [14987]) could be used as a good example.

Attachments (2)

tests.diff​ (4.4 KB ) - added by Andy Venet 13 years ago.
Made some tests based on the ones on simple_tag
patch2.diff​ (4.3 KB ) - added by Paul Bissex 13 years ago.
updated diff

Download all attachments as: .zip

Change History (11)

comment:1 by rasca, 13 years ago

Component: Uncategorized → Template system
Keywords: easy-pickings added
Triage Stage: Unreviewed → Accepted

Accepting the ticket and marking it as easy-picking

comment:2 by elbarto, 13 years ago

Owner: changed from nobody to elbarto

comment:3 by Andy Venet, 13 years ago

Owner: changed from elbarto to Andy Venet

comment:4 by Andy Venet, 13 years ago

Status: new → assigned

by Andy Venet, 13 years ago

Attachment: tests.diff​ added

Made some tests based on the ones on simple_tag

comment:5 by Andy Venet, 13 years ago

Has patch: set

comment:6 by Paul Bissex, 13 years ago

Owner: changed from Andy Venet to Paul Bissex
Status: assigned → new

comment:7 by Paul Bissex, 13 years ago

Patch needs improvement: set

by Paul Bissex, 13 years ago

Attachment: patch2.diff​ added

updated diff

comment:8 by Paul Bissex, 13 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:9 by Russell Keith-Magee, 13 years ago

Resolution: → fixed
Status: new → closed

In [15819]:

Fixed #14960 -- Added tests for inclusion tags. Thanks to Julien Phalip for the report, and to avenet and Paul Bissex for the patch.

Note: See TracTickets for help on using tickets.
Back to Top