Unique_for_[date|month|year] fails when the DateField is empty

[Ben Spaulding]

Using the following fields on a model:

slug = models.SlugField(unique_for_date='pubdate')
pubdate = models.DateTimeField(blank=True, null=True)

Leads to the following error when pubdate is left empty and one tries to save the model instance:

Django Version:	1.3 alpha 1
Exception Type:	AttributeError
Exception Value:	'NoneType' object has no attribute 'day'
Exception Location:	/Users/…/django/db/models/base.py in _perform_date_checks, line 744

(It appears that this issue was addressed years ago, but regressions happen. See #2155.)

[Russell Keith-Magee]

Regressions *shouldn't* happen -- that's what the test suite is for :-)

Since this is a regression, its a 1.3 blocker.

[Ramiro Morales]

(In [15167]) Fixed #14951 -- Made the unique_for_{date,month,year} model field constraints to not fail when the related DateField is empty.

Existing modelforms tests were extended to cover this case and an equivalent set of tests was added for the model functionality.

[Ramiro Morales]

I forgot to thank benspaulding in the commit message for bringing this regression to our attention.

[Ramiro Morales]

(In [15182]) [1.2.X] Fixed #14951 -- Made the unique_for_{date,month,year} model field constraints to not fail when the related DateField is empty.

Existing modelforms tests were extended to cover this case and an equivalent set of tests was added for the model functionality.

Backport of [15167] from trunk.

[Jacob]

Milestone 1.3 deleted