Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14946 closed (fixed)

Form wizard doesn't process last form

Reported by: Qrees Owned by: nobody
Component: contrib.formtools Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

FirmWizard call method calls done with current_form_list, which doesn't have last processed form appended:

File contrin/formtools/wizard.py (line 115):

if next_step == self.num_steps():
    return self.done(request, current_form_list)

Should be something like this:

if next_step == self.num_steps():
    final_form_list = current_form_list + [form]
    return self.done(request, final_form_list)

Attachments (1)

patch.diff (596 bytes) - added by Qrees 4 years ago.
Patch

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by Qrees

Patch

comment:1 Changed 4 years ago by ramiro

  • Resolution set to fixed
  • Status changed from new to closed

(In [15044]) [1.2.X] Fixed #14576, #14946 - FormWizard.done() method doesn't get passed the last form in the list.

Thanks to cyberdelia for report and test, and steph for the initial patch.

Backport of r14574 from trunk.

comment:2 Changed 4 years ago by ramiro

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

@Qrees,

Unfortunately this issue had been fixed (with an implementation very similar to yours) in mainline development but somehow slipped from our 'Backport fixes to 1.2.X branch' process and thus, missed the possibility to be included in the recently tagged 1.2.4 bug-fix release.

This means you will need to either a) manually apply the fix to the 1.2.x release you are using or b) to track the 1.2.X development branch.

Thanks for bringing this to our attention and for sumbitting a fix.

Note: See TracTickets for help on using tickets.
Back to Top