Opened 14 years ago
Closed 13 years ago
#14898 closed Cleanup/optimization (wontfix)
Move validate_sql functionality into backend
| Reported by: | Christophe Pettus | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 1.3-alpha |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Right now, RawQuery.validate_sql does one thing: It statically checks to see if the query begins with "SELECT". In the case of some backends (such as PostgreSQL), other statements can return sets, like FETCH (from a cursor) and DO. It would be great to use those in raw queries as well. Rather than just building up a large list in the function, I suggest that the list be moved into the backend, or the actual guts of validate_sql be delegated to it.
Change History (5)
comment:1 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Cleanup/optimization |
comment:3 by , 13 years ago
| UI/UX: | unset |
|---|
comment:5 by , 13 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
There is no more validation on raw sql (see #14733).
Note:
See TracTickets
for help on using tickets.
Change UI/UX from NULL to False.