Code

Opened 3 years ago

Closed 3 years ago

#14889 closed (wontfix)

Usability improvement to csrf_migration_helper

Reported by: frankvillasenor Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords: csrf_migration_helper, csrf, csrf migration
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The csrf_migration_helper.py couldn't find my settings file. I found that "." wasn't on my sys.path. I made a small modification to the csrf_migration_helper to go ahead and add "." to the path. While I realize I may not have been using the program quite as expected, I figure that if I ran in to this, others will and this is a quick fix.

Hopefully this is helpful.

Attachments (1)

curr_dir--csrf_migration_helper.patch (436 bytes) - added by frankvillasenor 3 years ago.
patch file with the additions I described in the ticket.

Download all attachments as: .zip

Change History (2)

Changed 3 years ago by frankvillasenor

patch file with the additions I described in the ticket.

comment:1 Changed 3 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

I disagree that munging PYTHONPATH or sys.path is a good thing to be doing here. Having a settings file that is found in one circumstance but not others just serves to add to the confusion of what the PYTHONPATH/sys.path is, or should be.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.