Opened 14 years ago
Closed 12 years ago
#14886 closed New feature (fixed)
GeoModelAdmin forms cannot be used with WMS in formats other than image/jpeg
| Reported by: | Paul Winkler | Owned by: | nobody |
|---|---|---|---|
| Component: | GIS | Version: | 1.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I'm using a subclass of contrib.gis.admin.GeoModelAdmin with http://maps.opengeo.org/geowebcache/service/wms as the wms_url.
The problem is that templates/gis/admin/openlayers.js does not allow specifying the image format, so it uses the OpenLayers default of image/jpeg,
which some base layers (notably http://maps.opengeo.org/geowebcache/service/wms) do not support.
So I have to fork a copy of the template just to add that one parameter to one line of javascript.
Patch that fixes this attached.
Attachments (2)
Change History (11)
by , 14 years ago
| Attachment: | geomodeladmin_format_patch.diff added |
|---|
comment:1 by , 14 years ago
| Has patch: | set |
|---|
comment:2 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → New feature |
As this adds to existing functionality, I'm marking it as a 'new feature'.
comment:4 by , 14 years ago
| Needs tests: | set |
|---|
comment:7 by , 13 years ago
| Needs tests: | unset |
|---|
comment:8 by , 12 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Planned to be committed soon.
comment:9 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
this version of the patch allows passing arbitrary options to the WMS layer constructor