Opened 6 years ago

Closed 4 years ago

#14874 closed Bug (wontfix)

remove js-confirms on changelist

Reported by: sehmaschine@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

see http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/media/js/actions.js:
just delete line 104 to 126.

why? because
a) trusted editors should know what they do.
b) triggering the change-function of form-fields may not capture all changes.
c) and probably most important: we don´t do that on the change-form. it´s all about coherence.

Change History (7)

comment:1 Changed 6 years ago by Julien Phalip

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

This is a fair request, but it needs some discussion as there are usability implications. I recommend you to bring this question up on the django-developers mailing list (1) and seek opinions from developers who are using this functionality in production with clients.

(1) http://groups.google.com/group/django-developers/topics

comment:2 Changed 5 years ago by James Addison

Severity: Normal
Type: Bug

comment:3 Changed 5 years ago by Julien Phalip

UI/UX: set

comment:4 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:6 Changed 5 years ago by Aymeric Augustin

UI/UX: set

Revert accidental batch modification.

comment:7 Changed 4 years ago by Jannis Leidel

Resolution: wontfix
Status: newclosed

apollo13 and me have discussed this at the Django sprint in Berlin and don't see enough reasons to remove this user facing feature. Inconsistencies in the code doesn't mean we should remove it completely, but rather consider fixing the other places to apply the same.

Note: See TracTickets for help on using tickets.
Back to Top