Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#14872 closed (fixed)

ZAPostCodeField doesn't pass *args or **kwargs to super().__init__

Reported by: idangazit Owned by: idangazit
Component: contrib.localflavor Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Arguments like "required=false" are ignored.

Attachments (1)

14872.diff (482 bytes) - added by idangazit 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by idangazit

comment:1 Changed 3 years ago by idangazit

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 3 years ago by Alex

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14956]) Fixed #14871, #14872 -- ZAIDField didn't handle alll EMPTY_VALUES correctly and ZAPostCodeField didn't respect *args or kwargs (such as required=False). Also converted South African localflavor doctests into unittests. We have always been at war with doctests. Thanks to Idan Gazit.

Fixing ZA localflavor clean() #14872

comment:3 Changed 3 years ago by Alex

(In [14980]) [1.2.X] Fixed #14871, #14872 -- ZAIDField didn't handle alll EMPTY_VALUES correctly and ZAPostCodeField didn't respect *args or kwargs (such as required=False). Also converted South African localflavor doctests into unittests. We have always been at war with doctests. Thanks to Idan Gazit. Backport of [14956].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.