Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#14857 closed Uncategorized (duplicate)

has_results cleanup

Reported by: Waldemar Kornewald Owned by: nobody
Component: Uncategorized Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The attached patch moves the SQL-specific code (just three lines) from sql.Query to SQLCompiler. This allows to override the has_results() behavior in the backend which is needed for NoSQL support. It would be nice if you could commit the patch. Thanks!

Attachments (1)

has_results.diff (1.4 KB) - added by Waldemar Kornewald 6 years ago.
patch against trunk

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Waldemar Kornewald

Attachment: has_results.diff added

patch against trunk

comment:1 Changed 6 years ago by Russell Keith-Magee

milestone: 1.3
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Duplicate of #13774

comment:2 Changed 6 years ago by Russell Keith-Magee

Resolution: wontfix
Status: newclosed
Summary: [patch] has_results cleanuphas_results cleanup

Sorry - not a duplicate -- pasted a comment into the wrong tab.

However, I'm going to mark this wontfix. NoSQL support isn't something that needs to be addressed piecemeal. This isn't the only place that raw SQL leaks out of the compiler; these leaks need to be addressed as a whole, not piecemeal. As I've told you *many* times Waldemar, NoSQL support is on my radar for 1.4, when we address merging Alex's query-refactor SoC branch.

comment:3 Changed 6 years ago by Waldemar Kornewald

Note that query-refactor doesn't contain anything that doesn't already exist in Django-nonrel, so I'd appreciate if you could at least take a look at Django-nonrel before you merge query-refactor (which BTW needs some more work). Anyway, I've started documenting all existing and missing changes in NoSqlSupport.

comment:4 Changed 3 years ago by Tim Graham

Easy pickings: unset
Resolution: wontfixduplicate
Severity: Normal
Type: Uncategorized
UI/UX: unset

Duplicate of #17339 which has been merged.

Note: See TracTickets for help on using tickets.
Back to Top