Opened 5 years ago

Closed 9 months ago

#14834 closed Bug (duplicate)

Colour issues in CSS - particularly documentation

Reported by: cogat Owned by: cogat
Component: Documentation Version: 1.2
Severity: Normal Keywords: sprintdec2010
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no


As part of a CSS audit (qv #11390) I ran a colour contrast checker over, and the issues it highlighted were:

  • code snippets: grey text on green (e.g. comments, 'self': low contrast)
  • code snippets: orange text on green (e.g. strings: low contrast for colour blind visitors)
  • "Questions/feedback: orange text on green (links: low contrast for colour-blind visitors)

The attached patch for pygments.css corrects the code snippets. However there are no css files in the repository so I'm unsure who will

Attachments (1)

pygments_css.diff (3.1 KB) - added by cogat 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by cogat

comment:1 Changed 5 years ago by cogat

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

The questions/feedback is in the footer by the way.

comment:2 Changed 5 years ago by cogat

And the CSS audit is #11930.

comment:3 Changed 5 years ago by gabrielhurley

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Good call on the contrast check. I'd made a mental note of the grey on green before, but had never gotten around to opening a ticket for it.

My concern with the current patch is that it makes the various colors all pretty similar. They all tend towards blending in with the black text, and at that point you've lost the advantage of code highlighting.

One thing I think might help would be lightening the background color of the code blocks rather than darkening the foreground colors. (That'd mean changing pre, .literal-block's background-color property)

So, whatever can be done to increase contrast without losing the clear distinction of the colors would improve this patch IMHO.

comment:4 Changed 5 years ago by jaddison

  • milestone 1.3 deleted
  • Severity set to Normal
  • Type set to Bug

comment:5 Changed 4 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:6 Changed 4 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:7 Changed 3 years ago by aaugustin

comment:8 Changed 9 months ago by timgraham

  • Resolution set to duplicate
  • Status changed from new to closed

After the redesign this is superseded by and tickets in that tracker.

Note: See TracTickets for help on using tickets.
Back to Top