Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#14812 closed (fixed)

Wrong processing of If-Modified-Since header

Reported by: alexey.smolsky@… Owned by: nobody
Component: Contrib apps Version: dev
Severity: Keywords: static files, If-Modified-Since
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ramiro Morales)

I have faced with this issue when Opera 10.63 sent requests like that:

'HTTP_IF_MODIFIED_SINCE': ': 1291108438, Wed, 20 Oct 2010 14:05:00 GMT',
'HTTP_USER_AGENT': 'Opera/9.80 (Windows NT 5.1; U; ru) Presto/2.6.30 Version/10.63'

It seems that IF_MODIFIED_SINCE header is invalid. I don't exactly why... But in RFC2616(HTTP/1.1) we can see a case: "...if the passed If-Modified-Since date is invalid, the response is exactly the same as for a normal GET". So I think, it would be better if django.contrib.staticfiles will handle this case with simple check. I've attached patch.

Attachments (1)

rev14693_staticfiles.diff​ (738 bytes ) - added by alexey.smolsky@… 14 years ago.

Download all attachments as: .zip

Change History (7)

by alexey.smolsky@…, 14 years ago

Attachment: rev14693_staticfiles.diff​ added

comment:1 by alexey.smolsky@…, 14 years ago

Has patch: set

comment:2 by Ramiro Morales, 14 years ago

Description: modified (diff)
Triage Stage: Unreviewed → Accepted

See also #14747.

comment:3 by Ramiro Morales, 14 years ago

Needs tests: set
Version: 1.2 → SVN

comment:4 by Ramiro Morales, 14 years ago

Resolution: → fixed
Status: new → closed

(In [14753]) Fixed #14812 -- Made parsing of the If-Modified-Since HTTP header more robust in presence of malformed values when serving static content. Thanks shaohua for the report, and alexey.smolsky@… for a similar report and patch.

comment:5 by Ramiro Morales, 14 years ago

(In [14754]) [1.2.X] Fixed #14812 -- Made parsing of the If-Modified-Since HTTP header more robust in presence of malformed values when serving static content. Thanks shaohua for the report, and alexey.smolsky@… for a similar report and patch.
Backport of r14753 from trunk.

comment:6 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top