Opened 13 years ago
Closed 5 months ago
#14810 closed New feature (wontfix)
Admin inline templates need blocks
| Reported by: | Simon Meers | Owned by: | abdulrahman |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | template, block, inheritance |
| Cc: | Julien Phalip, sehmaschine@… | Triage Stage: | Unreviewed |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This has been bugging me for years, but I've not spotted a matching ticket as yet. The admin/edit-inline/(stacked|tabular).html templates do not contain a single {% block %}, and are therefore quite useless when it comes to template inheritance. It is a common requirement to tweak a small fragment of these templates, but this cannot be done in a DRY manner at present.
I propose tidying up these templates and breaking them down into blocks to solve this. More than happy to write the code, just thought I'd raise it here first to make sure I hadn't missed anything.
Attachments (1)
Change History (11)
comment:1 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
by , 13 years ago
| Attachment: | stacked_example.diff added |
|---|
Example stacked template with a few blocks (and indentation...?)
comment:2 by , 13 years ago
| Cc: | added |
|---|
comment:3 by , 13 years ago
| milestone: | 1.3 |
|---|---|
| Severity: | → Normal |
| Type: | → New feature |
Calling it a new feature as it's providing new 'functionality' for admin template developers.
comment:6 by , 15 months ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:7 by , 10 months ago
| Description: | modified (diff) |
|---|
comment:8 by , 10 months ago
| Has patch: | set |
|---|
The pull request:
https://github.com/django/django/pull/17030
comment:9 by , 10 months ago
| Needs documentation: | set |
|---|---|
| Patch needs improvement: | set |
comment:10 by , 5 months ago
| Has patch: | unset |
|---|---|
| Needs documentation: | unset |
| Patch needs improvement: | unset |
| Resolution: | → wontfix |
| Status: | assigned → closed |
| Triage Stage: | Accepted → Unreviewed |
Do to the lack of any replies on the forum, only a few replies in the ticket, and strong doubts as to whether this is really useful, I'll close the ticket as "wontfix".
title can already be customized with verbose_name/verbose_name_plural and using field-elements/table-body/table-headers will force users to rewrite almost the entire template, so they are not very useful either.
I'm fairly certain I've seen a similar ticket floating around before -- if not specifically about edit-inline, then about other aspects of the admin that could be made more modular.
Accepting on the basis that it's a good idea; if anyone knows or discovers the antecedent ticket, feel free to close this one.