No template tag to support contextual translations

[Jani Tiainen]

Implementation of #9988 provides only Python side solution. There is no built-in tag for contextual translations for templates.

[Jannis Leidel]

Yeah, this would probably should look like this:

with blocktrans

{% blocktrans with article.price as amount count i.length as years context "price" %}
    That will cost $ {{ amount }} per year.
{% plural %}
    That will cost $ {{ amount }} per {{ years }} years.
{% endblocktrans %}

with trans:

{% trans "yeah" context "greeting" noop %}

[Jannis Leidel]

Unfortunately we are in feature freeze mode, pushing to 1.4.

[Julien Phalip]

I'm working on this. Will post a patch soon.

[Aymeric Augustin]

herve (who reported #17045, a duplicate) is already working on a patch. He's "herve" on FreeNode too, you may want to check his status first.

[Julien Phalip]

I've posted a work in progress. {% Blocktrans %} and {% trans %} are both implemented, although only there are only tests for {% blocktrans %} at this stage. This will also need docs.

[Julien Phalip]

OK, I think that's it. Any feedback welcome. Thanks!

[Aymeric Augustin]

The patch looks very good and the documentation is clear.

I have only one question: shouldn't this example read context "greeting" rather than context="greeting"? It looks inconsistent with the docstring of do_block_translate and the regexps.

{% blocktrans with name=user.username context="greeting" %}Hi {{ name }}{% endblocktrans %} 

---

Unfortunately, I couldn't apply the patch to my checkout, even with git apply:

error: cannot apply binary patch to 'tests/regressiontests/i18n/other/locale/de/LC_MESSAGES/django.mo' without full index line
error: tests/regressiontests/i18n/other/locale/de/LC_MESSAGES/django.mo: patch does not apply

As a consequence, my review is based on code inspection. I didn't run the tests, but they look solid.

[Julien Phalip]

That's right, the syntax is context "xxx" and not context="xxx" -- I've fixed the doc example in the latest patch. I've also regenerated the *.mo file. I hope it works this time. Thanks for looking at the patch!

[Julien Phalip]

In [17015]:

Fixed #14806 -- Added support for contextual translations to the trans and blocktrans template tags. Thanks to jtiai for the report.