Opened 13 years ago

Closed 11 years ago

Last modified 11 years ago

#14786 closed Bug (fixed)

get_db_prep_lookup call get_prep_value twice for each value if prepared == False

Reported by: homm Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords: sprintdec2010 fields lookup
Cc: Jonas H. Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Łukasz Rekucki)

In db.models.fields.Field get_db_prep_lookup() check if value is prepared and prepare it:

def get_db_prep_lookup(self, lookup_type, value, connection, prepared=False):
    "Returns field's value prepared for database lookup."
    if not prepared:
        value = self.get_prep_lookup(lookup_type, value)

get_prep_lookup() call get_prep_value() for every value.

But look next:

elif lookup_type in ('exact', 'gt', 'gte', 'lt', 'lte'):
    return [self.get_db_prep_value(value, connection=connection, prepared=prepared)]
elif lookup_type in ('range', 'in'):
    return [self.get_db_prep_value(v, connection=connection, prepared=prepared) for v in value]

Prepared flag not changed and get_db_prep_value() call get_prep_value() through get_db_prep_value() again!

I think get_db_prep_lookup() should call get_db_prep_value() always with prepared == True.

elif lookup_type in ('exact', 'gt', 'gte', 'lt', 'lte'):
    return [self.get_db_prep_value(value, connection=connection, prepared=True)]
elif lookup_type in ('range', 'in'):
    return [self.get_db_prep_value(v, connection=connection, prepared=True) for v in value]

This bug is still unnoticed because in standard ORM get_db_prep_lookup() always calls with prepared == True.

Attachments (2)

14786_fix_with_tests.diff (2.8 KB ) - added by Aram Dulyan 13 years ago.
Fix with a regression test.
ticket14786.diff (2.4 KB ) - added by Łukasz Rekucki 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Jonas H., 13 years ago

Cc: Jonas H. added

by Aram Dulyan, 13 years ago

Attachment: 14786_fix_with_tests.diff added

Fix with a regression test.

comment:2 by Aram Dulyan, 13 years ago

Has patch: set
Keywords: sprintdec2010 fields lookup added
Triage Stage: UnreviewedAccepted
Version: 1.2SVN

comment:3 by anonymous, 13 years ago

Severity: Normal
Type: Bug

comment:4 by Łukasz Rekucki, 12 years ago

Description: modified (diff)
Easy pickings: unset
Patch needs improvement: set
UI/UX: unset

Patch doesn't apply cleanly, will try to rebase.

by Łukasz Rekucki, 12 years ago

Attachment: ticket14786.diff added

comment:5 by Łukasz Rekucki, 12 years ago

Patch needs improvement: unset

comment:6 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: newclosed

In f19a3669b87641d7882491c3590d3c1c79756197:

Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False.

Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.

comment:7 by Tim Graham <timograham@…>, 11 years ago

In 10d15f79e5e2ca7b733e2bf1860e1778c3a712dc:

[1.6.x] Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False.

Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.

Backport of f19a3669b8 from master

comment:8 by Simon Charette <charette.s@…>, 11 years ago

In 36bbe3b7c52d459ed4862bbad1b44541a58cda00:

Altered test introduced in f19a3669b8 for the sake of readability. refs #14786

Note: See TracTickets for help on using tickets.
Back to Top