get_db_prep_lookup call get_prep_value twice for each value if prepared == False

[homm]

In db.models.fields.Field get_db_prep_lookup() check if value is prepared and prepare it:

def get_db_prep_lookup(self, lookup_type, value, connection, prepared=False):
    "Returns field's value prepared for database lookup."
    if not prepared:
        value = self.get_prep_lookup(lookup_type, value)

get_prep_lookup() call get_prep_value() for every value.

But look next:

elif lookup_type in ('exact', 'gt', 'gte', 'lt', 'lte'):
    return [self.get_db_prep_value(value, connection=connection, prepared=prepared)]
elif lookup_type in ('range', 'in'):
    return [self.get_db_prep_value(v, connection=connection, prepared=prepared) for v in value]

Prepared flag not changed and get_db_prep_value() call get_prep_value() through get_db_prep_value() again!

I think get_db_prep_lookup() should call get_db_prep_value() always with prepared == True.

elif lookup_type in ('exact', 'gt', 'gte', 'lt', 'lte'):
    return [self.get_db_prep_value(value, connection=connection, prepared=True)]
elif lookup_type in ('range', 'in'):
    return [self.get_db_prep_value(v, connection=connection, prepared=True) for v in value]

This bug is still unnoticed because in standard ORM get_db_prep_lookup() always calls with prepared == True.

[Aram Dulyan]

Fix with a regression test.

[Łukasz Rekucki]

Patch doesn't apply cleanly, will try to rebase.

[Tim Graham <timograham@…>]

In f19a3669b87641d7882491c3590d3c1c79756197:

Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False.

Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.

[Tim Graham <timograham@…>]

In 10d15f79e5e2ca7b733e2bf1860e1778c3a712dc:

[1.6.x] Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False.

Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.

Backport of f19a3669b8 from master

[Simon Charette <charette.s@…>]

In 36bbe3b7c52d459ed4862bbad1b44541a58cda00:

Altered test introduced in f19a3669b8 for the sake of readability. refs #14786