Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14770 closed (wontfix)

Should be able to set cookies from the request as well as the response.

Reported by: Paul McLanahan Owned by: Paul McLanahan
Component: Core (Other) Version: master
Severity: Keywords: cookies
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The arguments are laid out quite well in a blog post by David Cramer. In short, one is never sure where in the request-response cycle the need to send a cookie to the browser will arise. It's therefore best, as it's done in many other web frameworks and technologies, to give the developer the ability to do that throughout the view.

David's example code from that blog post, and his subsequently released django-cookies project no longer work as of Django 1.2. I've taken a slightly different approach in my version of his idea, but it still requires a custom middleware to be installed.

I believe this should be a core function of Django. If you agree, please take a look at my patch. I've included tests and docs. Any feedback at all is most welcome.

Attachments (1)

django_ticket_14770.diff (9.8 KB) - added by Paul McLanahan 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Paul McLanahan

Has patch: set
Owner: changed from nobody to Paul McLanahan
Status: newassigned

Changed 7 years ago by Paul McLanahan

Attachment: django_ticket_14770.diff added

comment:2 Changed 7 years ago by Brodie Rao

Triage Stage: UnreviewedDesign decision needed

comment:3 Changed 7 years ago by Łukasz Rekucki

Resolution: wontfix
Status: assignedclosed

comment:4 Changed 7 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top