#14764 closed (fixed)
Docs and code disagree on return type of Users.get_all_permissions()
Reported by: | MostAwesomeDude | Owned by: | nobody |
---|---|---|---|
Component: | Uncategorized | Version: | 1.2 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
While implementing an authentication backend, I noticed that the documentation for get_all_permissions() (http://docs.djangoproject.com/en/dev/topics/auth/#django.contrib.auth.models.User.get_all_permissions) claims "Return a list", but the backend wrapper in django/contrib/auth/models.py:149, _user_get_all_permissions(), creates and returns a set instead of a list. This causes one of our internal unit tests to fail.
A set makes good sense here, but the documentation and code are in conflict with each other. Could I get a resolution?
(Patch not attached since I have no preference as to the actual fix.)
Change History (2)
comment:1 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [14787]) Fixed #14764 -- specified that a set is returned by User.get_..._permissions methods. Thanks MostAwesomeDude for the report.