Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14750 closed (fixed)

ILPostalCodeField doesn't handle EMPTY_VALUES correctly

Reported by: idangazit Owned by: idangazit
Component: contrib.localflavor Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Same issue as #14499.

Attachments (1)

14750.diff (876 bytes) - added by idangazit 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by idangazit

comment:1 Changed 6 years ago by idangazit

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to idangazit
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 6 years ago by idangazit

  • Has patch set

comment:3 Changed 6 years ago by idangazit

Not sure this needs tests since the existing tests already try out valid/invalid values as well as every member of EMPTY_VALUES.

comment:4 Changed 6 years ago by claudep

  • milestone set to 1.3
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:5 Changed 6 years ago by Alex

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14943]) Fixed #14750 -- ILPostalCodeField didn't handle all EMPTY_VALUES correctly. Also converted the Israeli localflavor testcases to use the new, less verbose format. Thanks to Idan Gazit.

comment:6 Changed 5 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top