Code

Opened 4 years ago

Closed 4 years ago

#14742 closed (invalid)

Allow each action to decide default value for select_across

Reported by: curtis@… Owned by: nobody
Component: contrib.admin Version: 1.3-alpha
Severity: Keywords: admin, actions
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It seems the "select_across" option in Admin actions is under-utilised [e.g. not at all].

It would allow an action to not require any selected items, instead operating on all matching the current filter spec.

However, because of a duplicate check it never gets the chance.

The attached patch removes the check, changes select_across to NullBooleanField, with Null as default, and will set it to the select_across property of the selected action if it has one, or False otherwise.

Attachments (1)

select_across.patch (2.1 KB) - added by curtis@… 4 years ago.

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by curtis@…

comment:1 Changed 4 years ago by curtis@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

Thanks to SmileyChris for making me realise I'd misunderstood the code.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.