#14735 closed (fixed)
Wrong plural formulation in search_form.html
Reported by: | Claude Paroz | Owned by: | Claude Paroz |
---|---|---|---|
Component: | contrib.admin | Version: | 1.2 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In search_form.html template from contrib.admin, the singular of the search results message is using a number (1) instead of the variable:
{% blocktrans count cl.result_count as counter %}1 result{% plural %}{{ counter }} results{% endblocktrans %}
This is fine in English, but is causing issues in languages where the singular might be used with more than one number, like 0 and 1 for French. Fix is trivial and requires using {{ counter }} in singular form also.
Attachments (2)
Change History (7)
by , 14 years ago
Attachment: | search_results_plural.diff added |
---|
comment:1 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
I looked at current translations, and my opinion is that we should not backport this fix, as it will break translations for a rather visible string and I doubt we have the required knowledge to guess the right change in various languages (64!).
I'm adding a second patch which includes fixes for Chinese translations, as the required changes to make them msgfmt -vc compliant are trivial. I let the committer decide if he wants to include translation fixes in the same commit or not.
by , 14 years ago
Attachment: | search_results_plural_zh.diff added |
---|
Include Chinese translations fixes
comment:3 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Add variable in singular form also