@last_modified should ignore lack of etag method when USE_ETAGS is enabled
|Reported by:||lamby||Owned by:||nobody|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||yes|
Using @last_modified with settings.USE_ETAGS does not work as expected.
My goal is to avoid evaluating the view for a select handful of expensive pages based on the Last-Modified header, and globally fallback to saving bandwidth with USE_ETAGS.
However, if you enable USE_ETAGS and the @last_modified decorator, the view is still evaluated despite the last_modified_func being a match with If-Modified-Since. This is because the client is providing an ETag header (added because USE_ETAGS is enabled) and django.views.decorators.http.condition uses that etag along with the fact that we did did not provide an etag_func argument as a reason for not returning 304.
Patch attached that disables this particular part of the logic if settings.USE_ETAGS is enabled.
Change History (10)
Changed 5 years ago by lamby
comment:1 Changed 4 years ago by russellm
- Component changed from Uncategorized to Core framework
- Has patch set
- Needs documentation unset
- Needs tests set
- Patch needs improvement set
- Triage Stage changed from Unreviewed to Accepted