Opened 8 years ago

Closed 8 years ago

#14714 closed (invalid)

Refactoring BaseHandler and company for DRYness

Reported by: Travis Swicegood Owned by: Travis Swicegood
Component: Core (Other) Version: master
Severity: Keywords: response, BaseHandler
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


I've outlined everything in a Pull Request on GitHub here:

It has links to the code in question, which is located in my response-clean-up branch on GitHub.

Change History (4)

comment:1 Changed 8 years ago by Travis Swicegood

Owner: changed from nobody to Travis Swicegood
Status: newassigned

comment:2 Changed 8 years ago by Travis Swicegood

Status: assignednew
Triage Stage: UnreviewedReady for checkin

Marking as ready for check-in. All tests continue to pass with this patch applied, so we should be good. If any other changes are necessary, please let me know.

comment:3 Changed 8 years ago by Travis Swicegood

Triage Stage: Ready for checkinUnreviewed

comment:4 Changed 8 years ago by Russell Keith-Magee

Resolution: invalid
Status: newclosed

This patch appears to be superceded by the changes added in r14393, about 3 weeks ago.

Note: See TracTickets for help on using tickets.
Back to Top