Code

Opened 3 years ago

Closed 3 years ago

#14714 closed (invalid)

Refactoring BaseHandler and company for DRYness

Reported by: tswicegood Owned by: tswicegood
Component: Core (Other) Version: master
Severity: Keywords: response, BaseHandler
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I've outlined everything in a Pull Request on GitHub here: https://github.com/django/django/pull/6

It has links to the code in question, which is located in my response-clean-up branch on GitHub.

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by tswicegood

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to tswicegood
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 3 years ago by tswicegood

  • Status changed from assigned to new
  • Triage Stage changed from Unreviewed to Ready for checkin

Marking as ready for check-in. All tests continue to pass with this patch applied, so we should be good. If any other changes are necessary, please let me know.

comment:3 Changed 3 years ago by tswicegood

  • Triage Stage changed from Ready for checkin to Unreviewed

comment:4 Changed 3 years ago by russellm

  • Resolution set to invalid
  • Status changed from new to closed

This patch appears to be superceded by the changes added in r14393, about 3 weeks ago.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.