Opened 10 years ago

Last modified 16 months ago

#14688 new Bug

BaseInlineFormSet does not support "auto_id"

Reported by: Victor Andrée Owned by: nobody
Component: Forms Version: master
Severity: Normal Keywords: formsets
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

BaseInlineFormSet.__init__ does not accept the auto_id argument, unlike its ancestors. Furthmore, its parent BaseModelFormSet takes **kwargs and passes them along.

I can't think of a good reason for this omission/difference. I've attached a small patch to "match" BaseInlineFormSet.__init__ with BaseModelFormSet.__init__. The patch puts the "new" auto_id argument last in order to maximize backwards compatibility (the order is different for BaseModelFormSet).

Arguably, both prefix and auto_id could be removed from the explicit arg list since they're just passed along (in both BaseModelFormSet and BaseInlineFormSet).

Attachments (1)

BaseInlineFormset-auto_id.patch (1.3 KB) - added by Victor Andrée 10 years ago.
Adds auto_id to BaseInlineFormSet

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Victor Andrée

Adds auto_id to BaseInlineFormSet

comment:1 Changed 10 years ago by Russell Keith-Magee

Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

comment:2 Changed 9 years ago by James Addison

Severity: Normal
Type: Bug

comment:3 Changed 8 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:4 Changed 8 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:5 Changed 16 months ago by Tobias Kunze

Has patch: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: fixed
Status: newclosed

This issue has been fixed some time ago: In e308cfc0e15 (7 years ago, a year after this issue was opened), BaseInlineFormSet started passing **kwargs in its super() call.

comment:6 Changed 16 months ago by Nick Pope

Has patch: set
Needs tests: set
Patch needs improvement: set
Resolution: fixed
Status: closednew

Reopening due to comment on discarded PR.

Note: See TracTickets for help on using tickets.
Back to Top