Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#14568 closed (fixed)

FormMixin.get_form should use keyword arguments for data & files

Reported by: mattmcc Owned by: nobody
Component: Generic views Version: master
Severity: Keywords: forms
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.forms.BaseForm's constructor defines all its arguments as keyword arguments, but generic views have always passed data and files as positional arguments. The switch to class-based views makes for a nice opportunity to change that.

Attachments (1)

14568-1.diff (967 bytes) - added by mattmcc 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by mattmcc

comment:1 Changed 4 years ago by mattmcc

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [14371]) Fixed #14568 -- Use keyword rather than positional arguments for form construction. Thanks to mattmcc for the report and patch.

comment:3 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.