#14568 closed (fixed)
FormMixin.get_form should use keyword arguments for data & files
Reported by: | Matt McClanahan | Owned by: | nobody |
---|---|---|---|
Component: | Generic views | Version: | master |
Severity: | Keywords: | forms | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | UI/UX: |
Description
django.forms.BaseForm's constructor defines all its arguments as keyword arguments, but generic views have always passed data and files as positional arguments. The switch to class-based views makes for a nice opportunity to change that.
Attachments (1)
Change History (4)
Changed 7 years ago by
Attachment: | 14568-1.diff added |
---|
comment:1 Changed 7 years ago by
Has patch: | set |
---|
comment:2 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
(In [14371]) Fixed #14568 -- Use keyword rather than positional arguments for form construction. Thanks to mattmcc for the report and patch.