Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14517 closed (fixed)

_supports_stddev checks for wrong exception

Reported by: Austin Gabel Owned by: Austin Gabel
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

STDDEV_POP SQL function is not supported in PostgreSQL <= 8.1 so a NotImplementedError exception is raised. The try: is looking for a DatabaseError exception instead of the NotImplementedError so self.supports_stddev never gets set to False.

Attachments (1)

14517_patch.diff (433 bytes) - added by Austin Gabel 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Austin Gabel

Attachment: 14517_patch.diff added

comment:1 Changed 6 years ago by Austin Gabel

Has patch: set
Status: newassigned
Triage Stage: UnreviewedReady for checkin

This is pretty trivial so I'm going to go ahead to set it to ready for checkin.

comment:2 Changed 6 years ago by Alex Gaynor

Resolution: fixed
Status: assignedclosed

Fixed in [14375].

comment:3 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top