Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#14504 closed (fixed)

Generic ListView pagination broken

Reported by: anonymous Owned by: nobody
Component: Generic views Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Looks like [1] should be doing a pop instead of a get, otherwise [2] overwrites the newly paginated object_list.

[1] ​http://code.djangoproject.com/browser/django/trunk/django/views/generic/list.py#L80
[2] ​http://code.djangoproject.com/browser/django/trunk/django/views/generic/list.py#L97

Attachments (2)

14504.diff​ (552 bytes ) - added by Sean Brant 14 years ago.
ticket14504.diff​ (6.7 KB ) - added by Łukasz Rekucki 14 years ago.
Patch with tests.

Download all attachments as: .zip

Change History (6)

by Sean Brant, 14 years ago

Attachment: 14504.diff​ added

comment:1 by Alex Gaynor, 14 years ago

Needs tests: set

by Łukasz Rekucki, 14 years ago

Attachment: ticket14504.diff​ added

Patch with tests.

comment:2 by Łukasz Rekucki, 14 years ago

Has patch: set
Needs tests: unset
Triage Stage: Unreviewed → Accepted

comment:3 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

(In [14372]) Fixed #14504 -- Corrected the way object_list is used in ListView to avoid overwriting context. Includes improved usage of unittest2 assertions. Thanks to Łukasz Rekucki for the final patch.

comment:4 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top