Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14477 closed (fixed)

minor typo in the examples of m2m_changed signal

Reported by: slink <gabor@…> Owned by: nobody
Component: Documentation Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the Signals chapter of the Django documentation, there is a minor typo. The m2m_changed model signal has actions with names "pre_add", "post_add", etc. described which is true. Right below in the two examples listed, the documentation only writes "add", "remove". It should write "pre_add"/"post_add" and "pre_remove"/"post_remove".

Attachments (1)

signals.patch (805 bytes) - added by andrews 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by gabrielhurley

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 4 years ago by andrews

comment:2 Changed 4 years ago by andrews

  • Has patch set

comment:3 Changed 4 years ago by gabrielhurley

  • Resolution set to fixed
  • Status changed from new to closed

(In [14304]) Fixed #14477 -- Corrects several instances of "add" and "remove" m2m_changed signal actions not having been updated to "pre_add", "post_add", etc. Thanks to slink and andrews for reporting several instances of it, and andrews for the draft patch.

comment:4 Changed 4 years ago by gabrielhurley

(In [14305]) [1.2.X] Fixed #14477 -- Corrects several instances of "add" and "remove" m2m_changed signal actions not having been updated to "pre_add", "post_add", etc. Thanks to slink and andrews for reporting several instances of it, and andrews for the draft patch.

Backport of [14304] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top