Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#14432 closed (fixed)

Tutorial import line missing (tiny correction)

Reported by: gorus Owned by: nobody
Component: Documentation Version: 1.2
Severity: Keywords: easy-pickings
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi, thanks a lot for the tutorial, it's great!

At the very end of Part 3, in the last highlighted code block, after the admin registration lines have been removed, the following line should remain:

from django.conf.urls.defaults import *

before the "urlpatterns = patterns(..." code block. Otherwise, the newly created polls/urls.py doesn't work correctly. Better yet, "*" could be replaced with "patterns".

Thanks again,
Anton

Attachments (1)

tutorial03.patch (488 bytes) - added by andrews 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by gabrielhurley

  • Keywords easy-pickings added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from Tutorial import line missing (tiny correction needed?) to Tutorial import line missing (tiny correction)
  • Triage Stage changed from Unreviewed to Accepted

Technically, a few lines earlier the tutorial tells you to "Copy the file mysite/urls.py to polls/urls.py." If you followed along verbatim, you'd still have the import lines at the top of that file.

However, for the sake of completeness, showing the suggestion import line in that last code block won't hurt.

Changed 5 years ago by andrews

comment:2 Changed 5 years ago by andrews

  • Has patch set

comment:3 Changed 5 years ago by gabrielhurley

  • Resolution set to fixed
  • Status changed from new to closed

(In [14302]) Fixed #14432 -- Added an import statement which was previously implied in tutorial 3's URLconf to make it as explicit as possible for new users. Thanks to gorus for the report and andrews for the patch.

comment:4 Changed 5 years ago by gabrielhurley

(In [14303]) [1.2.X] Fixed #14432 -- Added an import statement which was previously implied in tutorial 3's URLconf to make it as explicit as possible for new users. Thanks to gorus for the report and andrews for the patch.

Backport of [14302] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top