Code

Opened 4 years ago

Closed 3 years ago

#14425 closed (fixed)

Unused imports in contrib.admin

Reported by: robhudson Owned by: SmileyChris
Component: contrib.admin Version: 1.2
Severity: Keywords:
Cc: clong Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Attached is a patch which removes unused imports in all contrib.admin files. The tests continue to pass.

Attachments (1)

admin_imports.diff (6.1 KB) - added by robhudson 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by robhudson

comment:1 Changed 4 years ago by SmileyChris

  • Component changed from Uncategorized to django.contrib.admin
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to SmileyChris
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 4 years ago by SmileyChris

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14175]) Fixed #14425 -- Unused imports in contrib.admin. Thanks robhudson.

comment:3 Changed 3 years ago by clong

  • Resolution fixed deleted
  • Status changed from closed to reopened

This change breaks the example given in the admin actions documentation: http://docs.djangoproject.com/en/dev/ref/contrib/admin/actions/, specifically this line: selected = request.POST.getlist(admin.ACTION_CHECKBOX_NAME)

Should either add the line back to init.py: from django.contrib.admin.helpers import ACTION_CHECKBOX_NAME

Or change the documentation.

comment:4 Changed 3 years ago by clong

  • Cc clong added

comment:5 Changed 3 years ago by SmileyChris

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks clong, reverted in [14359].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.