Opened 6 years ago

Closed 6 years ago

#14425 closed (fixed)

Unused imports in contrib.admin

Reported by: Rob Hudson Owned by: Chris Beaven
Component: contrib.admin Version: 1.2
Severity: Keywords:
Cc: Chris Long Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Attached is a patch which removes unused imports in all contrib.admin files. The tests continue to pass.

Attachments (1)

admin_imports.diff (6.1 KB) - added by Rob Hudson 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by Rob Hudson

Attachment: admin_imports.diff added

comment:1 Changed 6 years ago by Chris Beaven

Component: Uncategorizeddjango.contrib.admin
Has patch: set
Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Chris Beaven
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 6 years ago by Chris Beaven

Resolution: fixed
Status: assignedclosed

(In [14175]) Fixed #14425 -- Unused imports in contrib.admin. Thanks robhudson.

comment:3 Changed 6 years ago by Chris Long

Resolution: fixed
Status: closedreopened

This change breaks the example given in the admin actions documentation:, specifically this line: selected = request.POST.getlist(admin.ACTION_CHECKBOX_NAME)

Should either add the line back to from django.contrib.admin.helpers import ACTION_CHECKBOX_NAME

Or change the documentation.

comment:4 Changed 6 years ago by Chris Long

Cc: Chris Long added

comment:5 Changed 6 years ago by Chris Beaven

Resolution: fixed
Status: reopenedclosed

Thanks clong, reverted in [14359].

Note: See TracTickets for help on using tickets.
Back to Top