Site's get_current() not thread safe?
|Reported by:||Kronuz||Owned by:||nobody|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Is the Site caching system thread safe? I don't think it is. The patch in Ticket #7517 (as well as the code for get_current()) will get invalid or deleted sites when Site objects get deleted/updated in other thread other than the one using get_current(), since the objects wont get invalidated from such other threads to the one making the request.
I would believe shared memory is needed for that, to invalidate the object in all threads (it can be done using a "sync" time in a shared memory medium (memcache even))
Change History (2)
comment:1 Changed 6 years ago by Alex
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Resolution set to invalid
- Status changed from new to closed