Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#14384 closed (fixed)

Installation documentation should avoid sys.path.append

Reported by: monokrome Owned by: Greg Wogan-Browne
Component: Documentation Version: 1.2
Severity: Keywords: documentation apache mod_wsgi
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Using Apache's mod_wsgi implementation (and I'm sure some others), there are cases where sys.path.append will add redundant items to the system path. The mod_wsgi documentation requests that, instead, developers use the following in order to avoid these redundancies:

import sys
path = '/usr/local/wsgi/modules'
if path not in sys.path:
    sys.path.append(path)

More information is available here: WSGIReloadMechanism

Attachments (1)

14384.patch (622 bytes ) - added by Greg Wogan-Browne 14 years ago.

Download all attachments as: .zip

Change History (6)

by Greg Wogan-Browne, 14 years ago

Attachment: 14384.patch added

comment:1 by Greg Wogan-Browne, 14 years ago

Has patch: set
milestone: 1.3
Owner: changed from nobody to Greg Wogan-Browne
Status: newassigned
Triage Stage: UnreviewedAccepted

Agreed, the documentation should follow mod_wsgi best practices here.

The patch just contains the appropriate changes to the WSGI application without explanation. I'm not entirely sure whether a footnote is required or not.

comment:2 by Tim Graham, 14 years ago

Triage Stage: AcceptedReady for checkin

comment:3 by Russell Keith-Magee, 14 years ago

Resolution: fixed
Status: assignedclosed

(In [14016]) Fixed #14384 -- Updated mod_wsgi docs to match documented best practice. Thanks to monokrome for the report and wogan for the patch.

comment:4 by Russell Keith-Magee, 14 years ago

(In [14024]) [1.2.X] Fixed #14384 -- Updated mod_wsgi docs to match documented best practice. Thanks to monokrome for the report and wogan for the patch.

Backport of r14016 from trunk.

comment:5 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top