Opened 19 years ago
Closed 17 years ago
#1429 closed enhancement (invalid)
Yet another patch for SQL server adodbapi
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
From Matt Good, this patch works for him on top of 0.91.
Needs to be merged in against 0.91, have dj tests pass, then translated to magic-removal and pass those.
Attachments (1)
Change History (8)
by , 19 years ago
| Attachment: | adodbapi-from-0.91.patch added |
|---|
comment:1 by , 19 years ago
comment:3 by , 18 years ago
This news is a little late, but the pymssql authors have changed the license to LGPL: http://sourceforge.net/forum/forum.php?forum_id=566339
comment:6 by , 18 years ago
| Has patch: | set |
|---|---|
| Needs documentation: | set |
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
| Version: | magic-removal → SVN |
Patch is out of date. magic-removal was already merged.
comment:7 by , 17 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Thanks for uploading that patch. I should note that in the ADO backend I made the connection a
threading.localas an attempt to work around some threading problems I had, but that should probably be removed.Also, the patch included a change I made in
django.core.metato allow nullable many-to-one relationships, which I've heard will no longer be necessary on the magic-removal branch.The "mssql" backend in the patch is based on my "ado_mssql" backend and differs from the implementation in #1258 by parsing the LIMIT and OFFSET from the query instead of special-casing it in
django.core.meta. There is a special-case for enabling IDENTITY_INSERT (though I realized it's not turned back off as done in #1258, which may be a good idea).The pymssql module used in the "mssql" backend is currently GPL licensed, but I've contacted the authors and they are willing to relicense it under the LGPL. A new 0.8 release is supposed to be out shortly that will include the new license.