Code

Opened 8 years ago

Closed 6 years ago

#1429 closed enhancement (invalid)

Yet another patch for SQL server adodbapi

Reported by: jdunck@… Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

From Matt Good, this patch works for him on top of 0.91.

Needs to be merged in against 0.91, have dj tests pass, then translated to magic-removal and pass those.

Attachments (1)

adodbapi-from-0.91.patch (19.5 KB) - added by anonymous 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by anonymous

comment:1 Changed 8 years ago by Matt Good <django@…>

Thanks for uploading that patch. I should note that in the ADO backend I made the connection a threading.local as an attempt to work around some threading problems I had, but that should probably be removed.

Also, the patch included a change I made in django.core.meta to allow nullable many-to-one relationships, which I've heard will no longer be necessary on the magic-removal branch.

The "mssql" backend in the patch is based on my "ado_mssql" backend and differs from the implementation in #1258 by parsing the LIMIT and OFFSET from the query instead of special-casing it in django.core.meta. There is a special-case for enabling IDENTITY_INSERT (though I realized it's not turned back off as done in #1258, which may be a good idea).

The pymssql module used in the "mssql" backend is currently GPL licensed, but I've contacted the authors and they are willing to relicense it under the LGPL. A new 0.8 release is supposed to be out shortly that will include the new license.

comment:2 Changed 8 years ago by adrian

#1258 was another attempt.

comment:3 Changed 8 years ago by Matt Good

This news is a little late, but the pymssql authors have changed the license to LGPL: http://sourceforge.net/forum/forum.php?forum_id=566339

comment:4 Changed 8 years ago by Gary Wilson <gary.wilson@…>

  • milestone changed from Version 0.92 to Version 1.0

0.92 is long gone.

comment:5 Changed 7 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

comment:6 Changed 7 years ago by Gary Wilson <gary.wilson@…>

  • Has patch set
  • Needs documentation set
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from magic-removal to SVN

Patch is out of date. magic-removal was already merged.

comment:7 Changed 6 years ago by mtredinnick

  • Resolution set to invalid
  • Status changed from new to closed

As per #2358 and #3702, we're asking adosql development to be done out of tree for now.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.