Opened 6 years ago

Closed 6 years ago

#14257 closed (fixed)

Remove isValidIDList from ManyToManyField in django/db/models/fields/

Reported by: Andrii Kurinnyi Owned by: Andrii Kurinnyi
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


method isValidIDList seems to be an internal method used in Django before MultiDb.
It is not used anywhere in Django code now.
Also see #13771

Attachments (1)

rm_isValidIDList.diff (1.3 KB) - added by Andrii Kurinnyi 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Andrii Kurinnyi

Attachment: rm_isValidIDList.diff added

comment:1 Changed 6 years ago by Andrii Kurinnyi

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Andrii Kurinnyi
Patch needs improvement: unset
Status: newassigned

comment:2 Changed 6 years ago by Alex Gaynor

Resolution: fixed
Status: assignedclosed

(In [14602]) Fixed #14257 -- removed ManyToManyField.isValidIDList which was completely dead code (unused since magic-removal). Thanks to andrewsk for the patch.

Note: See TracTickets for help on using tickets.
Back to Top