Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#14254 closed (fixed)

More tests for storage backends

Reported by: steph Owned by: tobias
Component: File uploads/storage Version: 1.2
Severity: Keywords: tests
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

While working on a proposal to extend the storage backends, I recognised that some methods of the storage backends are not tested.

I just added tests to cover all methods of the backend to this ticket. I'm looking forward to see this committed.

Attachments (2)

storage_tests.diff (6.2 KB) - added by steph 5 years ago.
Patch to add more tests.
storage_tests_updated.diff (6.3 KB) - added by tobias 5 years ago.
updated tests to not care about listdir() ordering & properly clean up temp dirs

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by steph

Patch to add more tests.

comment:1 Changed 5 years ago by tobias

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to tobias
  • Patch needs improvement unset
  • Status changed from new to assigned

Changed 5 years ago by tobias

updated tests to not care about listdir() ordering & properly clean up temp dirs

comment:2 Changed 5 years ago by tobias

  • Triage Stage changed from Unreviewed to Ready for checkin

seems reasonable enough to me

comment:3 Changed 5 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [13852]) Fixed #14254 - More tests for storage backends

Thanks to steph for the patch, also to tobias for cleanups.

comment:4 Changed 5 years ago by lukeplant

(In [13854]) [1.2.X] Fixed #14254 - More tests for storage backends

Thanks to steph for the patch, also to tobias for cleanups.

Backport of [13852] from trunk

Note: See TracTickets for help on using tickets.
Back to Top