Opened 6 years ago

Closed 6 years ago

#14233 closed (invalid)

Documentation for admin is has a reference to meta class

Reported by: Peter of the Norse Owned by: nobody
Component: Documentation Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The page for contrib.admin still has meta class in an example:

class MyArticleAdminForm(forms.ModelForm):
    class Meta:
        model = Article

    def clean_name(self):
        # do something that validates your data
        return self.cleaned_data["name"]

Change History (3)

comment:1 Changed 6 years ago by Tim Graham

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Why is this a problem?

comment:2 Changed 6 years ago by Peter of the Norse

It’s misleading and confusing. Meta classes aren’t used any more, and we don’t need someone to look at it a wonder what it is. If we change it to albiwry = "The last starfighter" it’ll do the exact same thing.

comment:3 Changed 6 years ago by Peter of the Norse

Resolution: invalid
Status: newclosed

Sorry. I just noticed that this was a ModelForm, not ModelAdmin. My bad.

Note: See TracTickets for help on using tickets.
Back to Top