Code

Opened 4 years ago

Closed 3 years ago

#14230 closed (fixed)

Documentation for Auth's Logout view suggests wrong redirect takes precedence.

Reported by: Keryn Knight <keryn@…> Owned by: justinlilly
Component: contrib.auth Version: 1.2
Severity: Keywords: auth logout
Cc: kez.knight@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently, the documentation for django.contrib.auth.views.logout states

redirect_field_name: The name of a GET field containing the URL to redirect to after log out. Overrides next_page if the given GET parameter is passed.

However, as far as I can tell from staring at Trunk, this is only the case is next_page isn't also set. I appreciate it makes sense most of the time for only one to be provided, but as someone on IRC discovered, you can supply both (erroneously or not), at which point the documentation suggests the wrong one takes precedence.

Attachments (0)

Change History (4)

comment:1 Changed 4 years ago by andretavares

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I bumped into the same problem.

I think it isn't a documentation issue, as what is stated there makes perfect sense.

comment:2 Changed 4 years ago by justinlilly

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 3 years ago by justinlilly

  • Component changed from Documentation to Authentication
  • Owner changed from nobody to justinlilly
  • Status changed from new to assigned

I agree with andretavares that the documentation makes sense and the implementation does not.

comment:4 Changed 3 years ago by lasko

  • Resolution set to fixed
  • Status changed from assigned to closed

This issue was resolved with Ticket 11223 -- Revision: [15706]
Marking As Fixed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.