prepopulated_fields should concatenate fields in given order

[bmihelac]

When generating slug from more than one field order of fields in list should be respected.

Currently, the order in which fields are rendered in admin form affects the slug creation.

In the following example, slug would look "first_name-last_name" and I would expect "last_name-first_name".

class Person(models.Model):
    first_name = models.CharField(_('First name'), max_length=80)
    last_name = models.CharField(_('Last name'), max_length=80)

class PersonAdmin(admin.ModelAdmin):
    prepopulated_fields = {"slug": ('last_name', 'first_name')}

To change the order, one can swap the order in Person model, but it would be more naturally if populate would respect order that is given with tuple.

If you agree, I can make a patch for this.

[Luke Plant]

Agreed, patch gladly accepted! If this is just a javascript problem, you don't have to add tests since we don't have other tests for javascript functionality.

[bmihelac]

Because jQuery selected objects always return elements in document order I choosed to update prepopulate javascript function so it expects dependencies as array of field id's and not jQuery object.
Please let me know if you agree with this decission.

Patch is tested with regular admin forms, stacked and tabular formsets.

[Andrew Godwin]

(In [14122]) Fixed #14193: prepopulated_fields javascript now concatenates in correct order. Thanks to bmihelac for the patch.

[Andrew Godwin]

(In [14123]) [1.2.X] Fixed #14193: prepopulated_fields javascript now concatenates in correct order. Thanks to bmihelac for the patch.

Backport of [14122] from trunk

[Jacob]

Milestone 1.3 deleted